Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): disable return tip for partially configured pipette #13972

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

Laura-Danielle
Copy link
Contributor

@Laura-Danielle Laura-Danielle commented Nov 13, 2023

Overview

It is unsafe for us to return tips to a tiprack while in partial tip configuration because we risk the potential of picking up used tips. Also added a few more tests for the virtual configured nozzle state to make sure it's functioning as expected.

Closes RSS-360

Test Plan

  • Try to return tip when pipette is in partially configured state and see that it fails
  • Try to return tip in default state and see that it succeeds.

@Laura-Danielle Laura-Danielle requested a review from a team as a code owner November 13, 2023 20:24
@Laura-Danielle Laura-Danielle removed the request for review from a team November 13, 2023 20:25
@Laura-Danielle Laura-Danielle self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #13972 (3348189) into edge (3b59962) will not change coverage.
Report is 9 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13972   +/-   ##
=======================================
  Coverage   70.66%   70.66%           
=======================================
  Files        2505     2505           
  Lines       70869    70869           
  Branches     8751     8751           
=======================================
  Hits        50080    50080           
  Misses      18648    18648           
  Partials     2141     2141           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/opentrons/protocol_engine/commands/drop_tip.py 100.00% <ø> (ø)
...pi/src/opentrons/protocol_engine/state/geometry.py 100.00% <ø> (ø)
...pi/src/opentrons/protocol_engine/state/pipettes.py 100.00% <ø> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me

@sfoster1 sfoster1 force-pushed the RSS-360-disable-return-tip branch from 62fe583 to 504aa79 Compare November 16, 2023 17:41
@sfoster1 sfoster1 changed the base branch from edge to fix-partial-pickup-sim November 16, 2023 17:42
Base automatically changed from fix-partial-pickup-sim to edge November 16, 2023 17:42
Laura-Danielle and others added 3 commits November 16, 2023 12:43
It is unsafe for us to return tips to a tiprack while in partial tip configuration because we risk
the potential of picking up used tips.

RSS 360
@sfoster1 sfoster1 force-pushed the RSS-360-disable-return-tip branch from 504aa79 to dc90538 Compare November 16, 2023 17:43
@sfoster1 sfoster1 merged commit afe23d4 into edge Nov 16, 2023
@sfoster1 sfoster1 deleted the RSS-360-disable-return-tip branch November 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants